Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: App Store Connect threatens to block OneSignal apps #127

Open
1 task done
DaveBrask opened this issue Oct 19, 2024 · 3 comments
Open
1 task done

[Bug]: App Store Connect threatens to block OneSignal apps #127

DaveBrask opened this issue Oct 19, 2024 · 3 comments

Comments

@DaveBrask
Copy link

DaveBrask commented Oct 19, 2024

What happened?

App Store Connect sent an email threatening to block OneSignal apps:

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/OneSignalCore.framework/OneSignalCore”, which includes OneSignalCore, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/OneSignalOutcomes.framework/OneSignalOutcomes”, which includes RxSwift, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

Steps to reproduce?

Submit to App Store Connect for review

What did you expect to happen?

I didn't expect the app store to object.

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bnoffer
Copy link

bnoffer commented Oct 28, 2024

I presume this is due to the DotNet SDK not yet being updated with the latest iOS Frameworks. Due to a incompatibility with XCode 16 in combination with .NET 8.0.403 I manually built the DotNet SDK against the OneSignal.XCFramework v. 5.2.5 which resolved the compilation issues I had and it passed the App Store without any issues. Therefore I would say this post is related to my post #125 .

@dombartenope
Copy link

The .NET SDK is a wrapper on top of the iOS Native SDK where these privacy manifests were added in native release v5.2.0

This should be resolved by updating the .NET SDK to the same version that supports the iOS release that contains these privacy manifests v5.2.0

@bnoffer
Copy link

bnoffer commented Jan 15, 2025

I used the .NET SDK v. 5.2.1 before running into the issues with iOS 18 and yes it worked fine with iOS 17. Therefore it was not an issue with the privacy manifests which were introduced with iOS 17 by the way. As mentioned above manually updating the iOS SDK to v. 5.2.5 resolved the issue. I have seen that you started work on the .NET SDK v. 5.2.2 which pushes the iOS SDK to v. 5.2.9, that should fix the issue for everyone. Any estimate when this will release? Because I would like not having to use my custom build in production any longer then I have to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants