-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BBP RTQC (Dall'Olmo et al) #57
Comments
CSIRO does this |
Not yet. JMA will introduce BBP RTQC by ADMT-26. |
Completed for MEDS with the exception of filling BBP_ADJUSTED in RT which will be done by end of year. |
We are in the process of implementing this at MBARI. We ran into some confusion about the language used for when a test is aborted. The language suggests that when a test is aborted, the test is not applied successfully. However, our understanding is that when a test is aborted, the reason why the test was aborted determines whether or not the test is applied. For example, if there is not enough data for the test to progress, the test is aborted and we assume not applied. If the test completes all steps and the final result does not exceed a failure threshold, the test is aborted but we assume the test was successfully applied. This distinction is not clear in the literature and impacts how we report RTQC_APPLIED in the SCI_CAL_COMMENT. For the utility of cross-DAC analysis of these RTQC tests, we wanted to confirm how DACS were reporting RTQC_APPLIED in cases where the test is aborted. Thank you! |
Dear @catsch would you be able to please share what is being done at Coriolis? |
In the documentation https://doi.org/10.13155/60262 To correctly fill the RTQC_APPLIED, for some schemas of the documentation, you should not take into account the last "Abort" (Figure 2, Figure 4 and Figure 5 in the documentation / Figure 5, Figure 8 and Figure 14 in the Open research Europe review) to fill the RTQC_APPLIED for example for float 3901531 (profile 125) we got RTQC_APPLIED=11111 and RTQC_FAILED=01001 (high deep value test and parking hook test failed ) I hope it helps |
The text was updated successfully, but these errors were encountered: