Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BBP RTQC (Dall'Olmo et al) #57

Open
3 of 8 tasks
catsch opened this issue Jun 17, 2024 · 6 comments
Open
3 of 8 tasks

Implement BBP RTQC (Dall'Olmo et al) #57

catsch opened this issue Jun 17, 2024 · 6 comments

Comments

@catsch
Copy link

catsch commented Jun 17, 2024

  • aoml
  • bodc
  • coriolis
  • csio
  • csiro
  • incois
  • jma
  • meds
@jlovellcsiro
Copy link

CSIRO does this

@Argo-JMA
Copy link

Not yet. JMA will introduce BBP RTQC by ADMT-26.

@cgrdn
Copy link

cgrdn commented Oct 23, 2024

Completed for MEDS with the exception of filling BBP_ADJUSTED in RT which will be done by end of year.

@nicolagMBARI
Copy link

We are in the process of implementing this at MBARI.

We ran into some confusion about the language used for when a test is aborted. The language suggests that when a test is aborted, the test is not applied successfully. However, our understanding is that when a test is aborted, the reason why the test was aborted determines whether or not the test is applied.

For example, if there is not enough data for the test to progress, the test is aborted and we assume not applied. If the test completes all steps and the final result does not exceed a failure threshold, the test is aborted but we assume the test was successfully applied.

This distinction is not clear in the literature and impacts how we report RTQC_APPLIED in the SCI_CAL_COMMENT.

For the utility of cross-DAC analysis of these RTQC tests, we wanted to confirm how DACS were reporting RTQC_APPLIED in cases where the test is aborted.

Thank you!

@grgdll
Copy link

grgdll commented Nov 7, 2024

We are in the process of implementing this at MBARI.

We ran into some confusion about the language used for when a test is aborted. The language suggests that when a test is aborted, the test is not applied successfully. However, our understanding is that when a test is aborted, the reason why the test was aborted determines whether or not the test is applied.

For example, if there is not enough data for the test to progress, the test is aborted and we assume not applied. If the test completes all steps and the final result does not exceed a failure threshold, the test is aborted but we assume the test was successfully applied.

This distinction is not clear in the literature and impacts how we report RTQC_APPLIED in the SCI_CAL_COMMENT.

For the utility of cross-DAC analysis of these RTQC tests, we wanted to confirm how DACS were reporting RTQC_APPLIED in cases where the test is aborted.

Thank you!

Dear @catsch would you be able to please share what is being done at Coriolis?
thanks!

@catsch
Copy link
Author

catsch commented Nov 12, 2024

In the documentation https://doi.org/10.13155/60262
we mention two strings : RTQC_APPLIED and RTQC_FAILED to be reported in the SCI_CAL_COMMENT
RTQC_APPLIED is 1 when the test completes all steps of the test
RTQC_FAILED is 1 when the final result exceed the threshold

To correctly fill the RTQC_APPLIED, for some schemas of the documentation, you should not take into account the last "Abort" (Figure 2, Figure 4 and Figure 5 in the documentation / Figure 5, Figure 8 and Figure 14 in the Open research Europe review) to fill the RTQC_APPLIED

for example for float 3901531 (profile 125) we got RTQC_APPLIED=11111 and RTQC_FAILED=01001 (high deep value test and parking hook test failed )

I hope it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants