From 3970e9e28b3d954da797fd7dc590bad640e1ef9b Mon Sep 17 00:00:00 2001 From: Kenny Rasschaert Date: Wed, 28 Nov 2018 16:51:30 +0100 Subject: [PATCH 1/2] Added support for arbitrary extension commands --- README.md | 1 + templates/etc/snmp/snmpd.conf.j2 | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/README.md b/README.md index 8c87ea8..4e09663 100644 --- a/README.md +++ b/README.md @@ -37,6 +37,7 @@ on **Ubuntu** this package is in **multiverse**. See the *"Recommended"* section * `snmpd_default_monitors` [default: `true`]: * `snmpd_link_up_down_notifications` [default: `true`]: +* `snmpd_extensions`: [default: `[]`]: List of extension names and commands ## Dependencies diff --git a/templates/etc/snmp/snmpd.conf.j2 b/templates/etc/snmp/snmpd.conf.j2 index b9a44f2..971b710 100644 --- a/templates/etc/snmp/snmpd.conf.j2 +++ b/templates/etc/snmp/snmpd.conf.j2 @@ -31,5 +31,11 @@ disk {{ snmpd_disk.path }} {{ snmpd_disk.threshold }} defaultMonitors {{ 'yes' if snmpd_default_monitors else 'no' }} linkUpDownNotifications {{ 'yes' if snmpd_link_up_down_notifications else 'no' }} +{% if snmpd_extensions is defined %} + +{% for snmpd_extension in snmpd_extensions %} +extend {{ snmpd_extension.name }} {{ snmpd_extension.command }} +{% endfor %} +{% endif %} master agentx From 73575e5420e895fb4e0cf0bbf99bb7637eb7f47e Mon Sep 17 00:00:00 2001 From: Kenny Rasschaert Date: Thu, 29 Nov 2018 13:02:18 +0100 Subject: [PATCH 2/2] got rid of the if statement that tests if snmpd_extensions is defined --- templates/etc/snmp/snmpd.conf.j2 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/templates/etc/snmp/snmpd.conf.j2 b/templates/etc/snmp/snmpd.conf.j2 index 971b710..a17e82c 100644 --- a/templates/etc/snmp/snmpd.conf.j2 +++ b/templates/etc/snmp/snmpd.conf.j2 @@ -31,11 +31,9 @@ disk {{ snmpd_disk.path }} {{ snmpd_disk.threshold }} defaultMonitors {{ 'yes' if snmpd_default_monitors else 'no' }} linkUpDownNotifications {{ 'yes' if snmpd_link_up_down_notifications else 'no' }} -{% if snmpd_extensions is defined %} -{% for snmpd_extension in snmpd_extensions %} +{% for snmpd_extension in snmpd_extensions | default([]) %} extend {{ snmpd_extension.name }} {{ snmpd_extension.command }} {% endfor %} -{% endif %} master agentx