-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Station groups #89
Station groups #89
Conversation
src/components/Explore/Map.tsx
Outdated
@@ -10,17 +11,24 @@ import { | |||
MapActionDispatcherContext | |||
} from '../../store/contexts'; | |||
import { layerStyles, mapStyle } from '../Map/styles'; | |||
import { directionArrow, pulsingDot, runWhenReady } from '../Map/utils'; | |||
import { getFeatureBounds, loadStaionIcons, runWhenReady } from '../Map/utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in loadStaionIcons, it should be loadStationIcons.
src/components/Explore/Map.tsx
Outdated
station: newSelectedStation | ||
}); | ||
selectedStationRef.current = newSelectedStation; | ||
const evenListener = (e: MapLayerEventType['click']) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in evenListener, I think it should be eventListener
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good and works fine. I found a bug not related to this PR but in general which I will create a separate issue. Please address the typo and I will merge it.
Great Work!! |
Regarding the SVG or PNG icons, I will talk to Chris about it in the meeting. but by any chance, is it possible for us to output the SVG files? |
Right now the exported data from canvas is PNG I believe. I don't know if I could turn them into SVGs, but I believe there are libraries that can render GeoJSONs directly as SVGs and I could try them out. Since they are now rendered on canvas and there are only a handful of them, I think I could download them manually from the rendered web page into image files, but then it would be difficult to make changes to those icons later. |
Changes:
Issues: