Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Peer Recognition feature #3175

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

added Peer Recognition feature #3175

wants to merge 9 commits into from

Conversation

tsu-ki
Copy link
Contributor

@tsu-ki tsu-ki commented Jan 1, 2025

Closes: #2576

Remaining changes:

  1. Failed to send kudos. Please try again. message is prompted even when the team member exists, but the kudos is sent.
Screen.Recording.2025-01-01.at.7.15.45.PM.mov

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please simplify this to be on the user's profile page, so it's a button with a list of people who gave kudos, there would be no text entry.

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Jan 2, 2025

@DonnieBLT sir I've made the requested changes, please review them? thank you!

Screen.Recording.2025-01-03.at.2.23.34.AM.mov

@tsu-ki tsu-ki marked this pull request as ready for review January 2, 2025 20:56
@tsu-ki tsu-ki requested a review from DonnieBLT January 2, 2025 20:56
@tsu-ki tsu-ki force-pushed the teams branch 2 times, most recently from a025fa0 to 0828c46 Compare January 2, 2025 21:42
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a field for a URL? So I can give kudos to any link like a PR, blog post, tweet, etc…

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link for what the kudos is for and a optional comment

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Jan 17, 2025

Please add a link for what the kudos is for and a optional comment

Sir, should I add the link field in the teams kudos section or create a separate section for it?
Additionally, originally there was an optional text section, did you mean I should reincorporate that? (in reference to optional comment)

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Jan 17, 2025

@DonnieBLT sir, I've made the requested changes. Please review them and suggest any further required changes, thank you!

Screen.Recording.2025-01-17.at.6.14.49.PM.mov

@tsu-ki tsu-ki requested a review from DonnieBLT January 17, 2025 12:48
@tsu-ki tsu-ki force-pushed the teams branch 2 times, most recently from 4b636b6 to 62564db Compare January 17, 2025 14:33
@CodeWithBishal
Copy link
Contributor

@tsu-ki the UI could be improved

  • The banner for "Kudos sent successfully" is hidden under the header, need to improve its visibility
  • The modal for showing kudos received can be improved

@CodeWithBishal
Copy link
Contributor

CodeWithBishal commented Jan 26, 2025

Should the kudos be unique? @DonnieBLT
i.e. User A can receive only one kudos from another User B

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Jan 26, 2025

@CodeWithBishal I'm planning to make UI changes across entire team model which includes Joining/leaving team, viewing team requests etc. For this, I was planning to firstly implement all required functionalities and then make UI changes so they could be more consistent.
Secondly, since the user can receive links along with kudos, I believe they shouldn't be unique, as they can be praised for multiple contributions.

Please do let me know your views on this, thank you!

@CodeWithBishal
Copy link
Contributor

@tsu-ki That sounds good. Once you've implemented the mentioned features, we can focus on refining the UI. Please share the UI design with me for review before you begin coding.
For kudos, We need to establish a mechanism to prevent irrelevant kudos from being submitted.

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Jan 29, 2025

@DonnieBLT sir, this PR is ready to be reviewed. please do let me know if there are any further changes to be made, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants