-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Peer Recognition feature #3175
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please simplify this to be on the user's profile page, so it's a button with a list of people who gave kudos, there would be no text entry.
@DonnieBLT sir I've made the requested changes, please review them? thank you! Screen.Recording.2025-01-03.at.2.23.34.AM.mov |
a025fa0
to
0828c46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a field for a URL? So I can give kudos to any link like a PR, blog post, tweet, etc…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link for what the kudos is for and a optional comment
Sir, should I add the link field in the teams kudos section or create a separate section for it? |
@DonnieBLT sir, I've made the requested changes. Please review them and suggest any further required changes, thank you! Screen.Recording.2025-01-17.at.6.14.49.PM.mov |
4b636b6
to
62564db
Compare
@tsu-ki the UI could be improved
|
Should the kudos be unique? @DonnieBLT |
@CodeWithBishal I'm planning to make UI changes across entire team model which includes Joining/leaving team, viewing team requests etc. For this, I was planning to firstly implement all required functionalities and then make UI changes so they could be more consistent. Please do let me know your views on this, thank you! |
@tsu-ki That sounds good. Once you've implemented the mentioned features, we can focus on refining the UI. Please share the UI design with me for review before you begin coding. |
@DonnieBLT sir, this PR is ready to be reviewed. please do let me know if there are any further changes to be made, thank you! |
Closes: #2576
Remaining changes:
Failed to send kudos. Please try again.
message is prompted even when the team member exists, but the kudos is sent.Screen.Recording.2025-01-01.at.7.15.45.PM.mov