-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: Implement effective infinite scroll on the new home page #1632
Comments
Hey @errorassassin , The issue is that in views.py , we gather all the bugs in one go from the database, but we want it to happen as the user scrolls forward in the home page ? Is this what is to be implemented ? |
Yes, that would improve the user experience a lot. |
Can i work on this issue ? |
Sure, Feel free to assign the issue to yourself using /assign. P.S. also make sure the url changes after the pagination, e.g. after scroll when the page 2 is being loaded URL should contain "?page=2" hence it is easier to share a link to someone else with a specific page number. |
/assign |
please correct me if I'm wrong @CodeWithBishal , we are here trying to remove the pagination bar and implement it by scrolling through the page instead ? |
@aakash2330 yes correct |
/assign |
/assign |
@errorassassin How can we navigate to newhome page locally ? |
just go to [base url]/newhome which would be localhost:8000/newhome by default |
Got it thanks. |
/assign |
bugs in newhome which have are of different user and is_hidden=true they must be listed in the page or not. |
No! Replacing the and with or would hide every Issue that's not mine as the second condition would be true whenever the Issue is not mine (mine means the user seeing the homepage). We want to hide all the Issues that are hidden and not mine. |
thanks, got it. |
I fixed the issue in this commit db9d344 |
Hi @HanilJain, If you have created a PR for this commit feel free to mention it with #[PR-ID] |
fixed #1672 |
@errorassassin Hi can you close this issue |
@HanilJain I dont think that was quite as expected, the page still loads all the bugs on the initial reload. Once again, what I had in my mind was something similar to twitter, loading content as the user scrolls down. Loading all the bugs initially has massively increased the loading time too. |
observe the scrollbar on these social media websites like twitter |
@errorassassin Hi thanks for informing. |
@errorassassin I think it seems correct to me now. as new content can be seen loading and also the scroll bar. |
Let's revert this please. I like the pagination better. |
Bugheist is adapting a new homepage with all the bugs listed on the homepage. Currently, all the bugs load without even scrolling.
The new home page is currently hosted at https://www.bugheist.com/newhome.
The text was updated successfully, but these errors were encountered: