Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] m.tnm.download and m.cdo.download fail to build on Windows server due to using external Python library requests #976

Open
petrasovaa opened this issue Nov 1, 2023 · 0 comments · May be fixed by #977
Open

[Bug] m.tnm.download and m.cdo.download fail to build on Windows server due to using external Python library requests #976

petrasovaa opened this issue Nov 1, 2023 · 0 comments · May be fixed by #977
Assignees
@HuidaeCho
Labels
Python Related code is in Python Windows MS Windows specific

Comments

@petrasovaa
Copy link
Contributor

Name of the addon
m.tnm.download and m.cdo.download

Describe the bug
Windows compilation fails because external Python package requests is not available:
https://wingrass.fsv.cvut.cz/grass83/addons/grass-8.3.1/logs/m.tnm.download.log

I would suggest either add lazy loading to avoid the building issues on the server, or reimplement it with urllib which is readily available.
@petrasovaa petrasovaa added Windows MS Windows specific Python Related code is in Python labels Nov 1, 2023
@HuidaeCho HuidaeCho self-assigned this Nov 3, 2023
@HuidaeCho HuidaeCho linked a pull request Nov 6, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HuidaeCho HuidaeCho

Labels
Python Related code is in Python Windows MS Windows specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

m.(cdo|tnm).download: Replace requests with urllib HuidaeCho/grass-addons
2 participants
@HuidaeCho @petrasovaa