Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename 'scripts' directory to 'launchers' #3901

Closed
Tracked by #3394
johrstrom opened this issue Oct 24, 2024 · 1 comment
Closed
Tracked by #3394

rename 'scripts' directory to 'launchers' #3901

johrstrom opened this issue Oct 24, 2024 · 1 comment

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Oct 24, 2024

While we refactored the Launcher models and controllers recently, we left this one piece standing - the scripts directory itself. We should change the name of this directory before the 4.0 release.

This directory here:

def scripts_dir(project_dir)
Pathname.new("#{project_dir}/.ondemand/scripts")
end

I deferred this because there are likely a lot of tests that need to be updated.

@euler-room
Copy link
Contributor

fixed in #3922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants