Do we need global_atts%L2_Processor_Version?

[simonrp84]

I see in orac_preproc.F90 these lines of code (L682-684):

   ! Set this since it was removed from the command line but not removed from
   ! the global attributes.
   global_atts%L2_Processor_Version = '1.0'

If we're always setting this attribute to '1.0' is there any point in having it in the first place? Seems pointless and a candidate for tidying.

[caropoulsen]

As long as the git version is set some where this is invalid From: Simon Proud <[email protected]> Sent: 16 July 2018 15:24 To: ORAC-CC/orac <[email protected]> Cc: Subscribed <[email protected]> Subject: [ORAC-CC/orac] Do we need global_atts%L2_Processor_Version? (#6) I see in orac_preproc.F90 these lines of code (L682-684): ! Set this since it was removed from the command line but not removed from ! the global attributes. global_atts%L2_Processor_Version = '1.0' If we're always setting this attribute to '1.0' is there any point in having it in the first place? Seems pointless and a candidate for tidying. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#6>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Aig_r6nBtv7cAMzKgtKU633VLB1YvR3zks5uHKIZgaJpZM4VROOr>.

[simonrp84]

Ok, not sure about git version so I'll leave it for now.

[adamcpovey]

I use global_atts%file_version to track this as it turns up in the filename (which is handy). This attribute is required for CCI input, but we aren't conforming to any one standard with our outputs here so I'm not opposed to removing this attribute. Especially considering we haven't used it in the two years since this issue opened.