Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty callback body when converter process is crashing or being killed #3089

Open
1 task done
Willena opened this issue Jan 10, 2025 · 0 comments
Open
1 task done

Comments

@Willena
Copy link

Willena commented Jan 10, 2025

This issue is unique.

  • I have used the search tool and did not find an issue describing my bug.

Operating System of DocumentServer

Docker

Version information

8.1.1

Expected Behavior

When the converter process fails in background, an empty callback body should not be sent to the storage api.
Converter process error should be better handled.

Actual Behavior

When the converter process is failing in the document-server (in my case, being killed by the system), the storage service receive an invalid callback body.
The body is almost empty with nothing the storage server can do with.

Example of body received:

CallbackHandlerBody{
  filetype=null, 
  url=null, 
  key='xxx',
  changesurl=null,
  history=null,
  token='xxx',
  forcesavetype=COMMAND_SERVICE, 
  status=CORRUPTED_FORCE_SAVE,
  users=["xxx"],
  actions=null,
  userdata=null, 
  lastsave='2024-12-11T15:37:04.000Z',
  notmodified=null
}

Reproduction Steps

In docker environment:

  • Run the document-server with less than 1Gi memory limit
  • Edit a 350 page docx document with many images & tables
  • On save, observe the converter process being killed by system oom-killer due to being over 1Gi limit
    Expect to see something like ExitCode (code=0;signal=SIGKILL;error:-80) in converter logs.
  • Observe the storage service receiving an empty callback body.

Additional information

Linked with disscution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant