Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate keyring, renv and targets package requirements #135

Closed
anthonysena opened this issue May 8, 2024 · 0 comments · Fixed by #145
Closed

Eliminate keyring, renv and targets package requirements #135

anthonysena opened this issue May 8, 2024 · 0 comments · Fixed by #145
Milestone

Comments

@anthonysena
Copy link
Collaborator

anthonysena commented May 8, 2024

As noted in #102 and through feedback from multiple network studies, the required use of the keyring package inside of Strategus is problematic since it requires operating system dependencies and often user intervention to enter credentials.

The main goal with using keyring inside of Strategus was to facilitate a secure mechanism to store credentials. With some of the ideas put forward in other issues (#128), we may be able to find alternative approaches for credential management to eliminate the need for the keyring package dependency. For example, if a targets script is generated by Strategus the the credential management can also live outside of the Strategus package. Alternatively, we might adopt a file-based encryption approach that is agnostic to the operating system.

Following along these lines, part of the reason why we are using keyring was due to the way in which we are dynamically generating a targets script and running modules via renv. We should remove these package dependencies and allow for a user to use renv and optionally targets outside of the scope of Strategus per #29 .

@anthonysena anthonysena added this to the v1.0.0 milestone May 8, 2024
@anthonysena anthonysena changed the title Eliminate the keyring package requirement Eliminate keyring, renv and targets package requirements Jun 11, 2024
@anthonysena anthonysena linked a pull request Jul 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant