[14.0][BUG] stock_request_tier_validation: ValidationError dont check pending Tiers

[kaynnan]

Module

stock_request_tier_validation

Describe the bug

The module in v14.0 and v15.0 does not have the correct behavior in tier.validation, it ignores pending reviews when only SRO Tier Validation is activated, in versions 12 and 13 the behavior displayed a Warning indicating that there are pending reviews.

To Reproduce

Affected versions:

v14.0:

Steps to reproduce the behavior:

1. Create new tier.definition for Stock Request Order (only active SRO)
2. Create new SRO
3. Save
4. Request for Validation
5. Confirm

Expected behavior

Warning: "A validation process is still open for at least."

Additional context

Runboat v12.0 (Work):

Runboat v13.0 (Work):

cc @douglascstd @marcelsavegnago

[kaynnan]

I conducted some tests with the stock_request module and noticed that after implementing this change to obtain the status, which prevents stock.request.order from remaining in the open state when it has already been completed [14.0][IMP] stock_request: Convert the state field of stock.request.order as compute store to complete all use cases, the tier.validation of stock.request.order began to ignore pending reviews. This causes a significant issue where completed SROs or those needing to revert to draft status cannot perform this action if there are pending reviews.

Additionally, I performed tests using the previous commit [14.0][FIX] stock_request: set stock request order state to done when partially delivered, and the tier.validation for stock.request.order functioned individually as expected.

[kaynnan]

cc @victoralmau @pedrobaeza

[pedrobaeza]

Sorry, but that module is not ours and we are not even using it.

[kaynnan]

cc @ForgeFlow

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.