[RFC] Combine forcecreate="0" detection and loading data without creation

[StefanRijnhart]

Now that the compare noupdate xml script detects the value of forcecreate (1), and we can have a mode that allows to update data on existing items only (2), I'm thinking that these best be combined and that the load_data method should always pick apart each item and, if the item has the forcecreate='0' attribute, it is only actually loaded if the item already exists in the database.

What do you think @pedrobaeza, @hbrunn?

And do we need to keep the init_no_create mode in that case?

(1) OCA/OpenUpgrade#1060
(2) #80

[hbrunn]

talking code, this would mean checking for forcecreate in https://github.com/OCA/openupgradelib/pull/80/files#diff-3d7675eb1386de028dab1f879bdc4681R296 and changing the condition above to always read through _get_existing_records in the xml case, right? Aye!

[pedrobaeza]

@StefanRijnhart are you going to work on this then?

[StefanRijnhart]

@pedrobaeza I would when I encounter a use case (I don't think there is one at the moment?)

[pedrobaeza]

No, not yet indeed. Should we close this issue?

[StefanRijnhart]

I think we can leave it open, as a reminder if that is alright with you.

[pedrobaeza]

OK, I try to reduce the number of TODOs at maximum, but when it's not possible, better to keep it.