Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests might be needed #47

Open
4 tasks
Killerqu00 opened this issue Sep 16, 2024 · 2 comments
Open
4 tasks

Integration tests might be needed #47

Killerqu00 opened this issue Sep 16, 2024 · 2 comments
Assignees
Labels
Feature / Feedback Provide feedback on existing things or request an addition of something into the pack. Meta This describes a change that is not directly ingame.

Comments

@Killerqu00
Copy link
Collaborator

With the amount of complexity we are having in this modpack, there needs to be some way to verify that new changes don't break something.
Ideally, that should also verify that no softlocks in progression occur, but the key word is ideally - this might be too hard to implement in a way that doesn't require tons of manual upkeep, which is NOT something integration tests should do.

Potential changes:

  • No crash test - check that game launches without crashing and preferably before the heat death of the universe not too long
  • LMFT test - check that Load My Fucking Tags doesn't report any tags that are broken
  • KJS test - same as above but with KJS errors/warnings
  • Progression test (?) - check the lack of softlocks somehow
@Killerqu00 Killerqu00 added Feature / Feedback Provide feedback on existing things or request an addition of something into the pack. Meta This describes a change that is not directly ingame. labels Sep 16, 2024
@Killerqu00 Killerqu00 self-assigned this Sep 16, 2024
@NyagiByte
Copy link
Owner

The no crash and kubejs test just sorta naturally come during deving so i'm not sure making a point of those makes sense. For the LMFT we might just have to do a binary search to see what mod is unhappy. As for progression test i'm not sure how that would be automatable, i mostly rely on the early access group to help with that

@Killerqu00
Copy link
Collaborator Author

The no crash and kubejs test just sorta naturally come during deving so i'm not sure making a point of those makes sense.

kind of, but it still helps to see on a PR, for example

For the LMFT we might just have to do a binary search to see what mod is unhappy.

LMFT logs the broken tags, you just need to check where we use them and why they broke

As for progression test i'm not sure how that would be automatable, i mostly rely on the early access group to help with that

still thinking on it, but with exponential modpack scaling I doubt manual testing will be viable as an option to check the whole progression tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature / Feedback Provide feedback on existing things or request an addition of something into the pack. Meta This describes a change that is not directly ingame.
Projects
None yet
Development

No branches or pull requests

2 participants