Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make strings translatable #54

Open
ashhhleyyy opened this issue Mar 7, 2022 · 1 comment · May be fixed by #94
Open

Make strings translatable #54

ashhhleyyy opened this issue Mar 7, 2022 · 1 comment · May be fixed by #94
Labels
enhancement New feature or request

Comments

@ashhhleyyy
Copy link
Member

Currently all the messages are LiteralTexts embedded in the source, however its probably a good idea to move over to TranslatableText.

I'll see if I can take a look at this at some point this week 😄
@Gegy Gegy added the enhancement New feature or request label Jul 18, 2022
@haykam821
Copy link
Contributor

Note that to maintain server-side compatibility, I believe this mod would need to depend on or embed Server Translations API.

@themg95 themg95 linked a pull request Oct 10, 2024 that will close this issue
Open
@Restioson Restioson linked a pull request Oct 12, 2024 that will close this issue
Use translatable texts instead of literal ones #94
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use translatable texts instead of literal ones themg95/player-roles
3 participants
@Gegy @haykam821 @ashhhleyyy