Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp the Navigator #76

Merged
merged 27 commits into from
Sep 10, 2023
Merged

Revamp the Navigator #76

merged 27 commits into from
Sep 10, 2023

Conversation

Hugman76
Copy link
Member

@Hugman76 Hugman76 commented Aug 13, 2023 •
edited
Loading

This PR revamps the navigator menu mainly by separating games into categories.
This PR also:

I moved most of the game portal files to dedicated folders, when there was >1 game portal needed per game type. I feel like that cleans up greatly and makes all the game portals less confusing.

This PR requires NucleoidMC/nucleoid-extras#141.

@Hugman76 Hugman76 changed the title Navigator revamp Revamp the Navigator Aug 13, 2023
@Hugman76
Copy link
Member Author

This PR now requires NucleoidMC/nucleoid-extras#141.

@Hugman76
Copy link
Member Author

This PR now fixes #74, #77 and #78.

@Hugman76 Hugman76 marked this pull request as ready for review August 15, 2023 23:52
@Hugman76 Hugman76 marked this pull request as draft August 15, 2023 23:58
@Hugman76
Copy link
Member Author

Hugman76 commented Aug 15, 2023 •
edited
Loading

Drafting for now, I want to re-organize the categories a bit and give them descriptions. I'd also like to fix #48 with this.

@Hugman76 Hugman76 marked this pull request as ready for review August 16, 2023 15:02
@Hugman76
Copy link
Member Author

As haykam and I noted on Discord there is still a couple of changes needed:

  • Death Run, Siege, Survival Games, Dé à Coudre can have right-click functionality
  • Cursed modes can be included in the main navigator
  • Some Spleef game configs can get their level_break_interval field set to -1 if it's very high

I'm noting them down because otherwise I'd forget them (im going to take a shower 🐧 )

@Hugman76
Copy link
Member Author

I've adressed all of haykam's 10 reviews. I think the PR can finally be merged now.

haykam821
haykam821 reviewed Aug 28, 2023
View reviewed changes
data/nucleoid/game_portals/koth/root.json
Comment on lines +5 to 6
"nucleoid:koth/classic",
"nucleoid:koth/deathmatch",
Copy link
Contributor

@haykam821 haykam821 Aug 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the maps for the two King of the Hill modes that have multiple maps selectable?

data/nucleoid/game_portals/ascension/root.json
@@ -2,12 +2,10 @@
"type": "nucleoid_extras:styled/simple_menu",
"icon": "minecraft:rabbit_foot",
"games": [
"nucleoid:ascension/random",

"ascension:standard_ascension",
"nucleoid:ascension/cave"
Copy link
Contributor

@haykam821 haykam821 Aug 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only the standard configuration makes sense to include here, since Cave Ascension has the potential to be unplayable. Do you think that Cave Ascension could be moved to the cursed games?

@Patbox Patbox changed the base branch from 1.19 to main September 10, 2023 19:37
@Patbox Patbox merged commit 3793538 into NucleoidMC:main Sep 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haykam821 haykam821 haykam821 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Hugman76 @haykam821 @Patbox