-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not require torch #390
Not require torch #390
Conversation
The solution of wrapping the file in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LHBO Please look at #389 first as this is built directly on top of that so it includes that code as well. The "changed files" should reduce to just one file one that is merged. Sorry about that.
The solution of wrapping the file in requireNamespace
seems fine to me. However, need to incorporate the requested changes from #389 before merging.
Should one in this PR also add the following check to
|
I am still not able to make this work out. What I have tried:
To show the issues, in the pushed code memory_layer() is defined without conditioning, skip_connection is defined as in point 3, and the rest is as in point 2. I don't know how to proceed with this for now. One (unsatisfactory) last way out of this is perhaps to delete all documentation for these objects? @LHBO Feel free to try to solve it. If we don't succeed, we may try to create a small reproducable example package with this issue and bring it on stack overflow or similar... |
This was fixed in #393 and we therefore close this PR. |
Currently, installation of shapr fails if torch is not installed, even though torch is only needed for the vaeac approach and included as a suggested package.
The code in this PR is tested and works in a local environment which does not have torch installed.