-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the library to core + react hooks #142
Comments
Hello @grobitto! Thanks for reaching out and apologies for the delayed response. Regarding your question, it should already be possible to do this, since we're exposing most of the core logic used - There's a note around this in the documentation here: https://github.com/NoriginMedia/Norigin-Spatial-Navigation?tab=readme-ov-file#navigation-service. As such I will close this issue, but please feel free to reopen this or create any new issues that you might find as part of achieving this. Happy coding! |
I've tried this way, but there is an @internal annotation on SpatialNavigation export, preventing it to be used outside of your module
|
Hello again
The service (class) instance itself is contained, but we export most of the functions it has: export const {
init,
setThrottle,
destroy,
setKeyMap,
setFocus,
navigateByDirection,
pause,
resume,
updateAllLayouts,
getCurrentFocusKey,
doesFocusableExist,
updateRtl
} = SpatialNavigation; Or are there perhaps other parts of the service that you would expect or need to have exposed? |
I've checked your code from useFocusable.ts, and here is the list of functions not exported from SpatialNavigation: |
@grobitto: Alright, then we'll have a discussion internally around what we can do to expose those. Thanks for letting us know. |
I think what we will do is remove the We'll follow up and highlight it here in this issue, once that change has been made. |
Thank you! |
Hello NoriginMedia,
We’re planning to use SolidJS for our upcoming SmartTV project and are interested in incorporating your spatial navigation library. While converting your React hooks to SolidJS isn’t too difficult, it would require cloning the entire project, which could result in missing future updates to your engine.
It would be fantastic if the core of your library could be provided as a standalone module.
The text was updated successfully, but these errors were encountered: