Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODOs for hardhat-ethers V3 when V3 features are ready #5788

Open
ChristopherDedominici opened this issue Sep 27, 2024 · 0 comments
Open

TODOs for hardhat-ethers V3 when V3 features are ready #5788

ChristopherDedominici opened this issue Sep 27, 2024 · 0 comments
Assignees
@ChristopherDedominici
Labels
v-next A Hardhat v3 development task

Comments

@ChristopherDedominici
Copy link
Contributor

ChristopherDedominici commented Sep 27, 2024 •
edited
Loading

HardhatEthersSigner

Revisit the 'create' method in HardhatEthersSigner

Example project

Remove the explanation in the script on how to run hardhat-ethers using a V2 node

hardhat-ethers README

Remove the explanation on how to run hardhat-ethers using a V2 node

Tests

Modify tests:

  • add support for hardhat node in tests, search for TODO: enable when V3 is ready

Delete TMP files:

  • delete the run-tests.ts file
  • delete the pnpm test:tmp command
  • update the initializeTestEthers helper function at the path ./test/helpers/helpers.ts
  • move the tests from the test-tmp folder to the test folder and delete the test-tmp folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristopherDedominici ChristopherDedominici

Labels
v-next A Hardhat v3 development task
Projects
Hardhat
Status: To-do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kanej @ChristopherDedominici