Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .patch version getter #150

Open
szszszsz opened this issue Jan 17, 2019 · 1 comment
Open

Add .patch version getter #150

szszszsz opened this issue Jan 17, 2019 · 1 comment
Labels
easy enhancement
Milestone
v3.9

Comments

@szszszsz
Copy link
Member

Add getter for the .patch part (as in x.y.patch) library version.

Related #35
@szszszsz szszszsz added this to the v3.5 milestone Jan 17, 2019
@robinkrahl
Copy link
Contributor

Two suggestions regarding version handling:

  • If you have to manually set the major, minor and patch version in version.cc anyway, we can remove the code to automatically generate them.
  • Regarding the version string: Currently, it is hard to tell whether this string will contain useful information. Therefore, my suggestion is to either completely remove the string, or to leave it empty if libnitrokey is not built from the Git repository (so that clients can detect whether it contains useful information).

@szszszsz szszszsz modified the milestones: v3.5, v3.6 Jul 10, 2019
sgued pushed a commit to sgued/libnitrokey that referenced this issue Feb 14, 2022
@robin-nitrokey
Merge pull request Nitrokey#150 from robin-nitrokey/nk3-update-error
418c4af 
nk3: Show bootloader error if firmware update fails
@szszszsz szszszsz added the easy label Apr 27, 2022
@szszszsz szszszsz modified the milestones: v3.7, v3.8 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy enhancement
Projects
None yet
Milestone
v3.9
Development

No branches or pull requests
2 participants
@robinkrahl @szszszsz