Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user run commands before and after build process. #6

Open
2 tasks
Niraj-Kamdar opened this issue Sep 14, 2020 · 2 comments
Open
2 tasks

Let user run commands before and after build process. #6

Niraj-Kamdar opened this issue Sep 14, 2020 · 2 comments

Comments

@Niraj-Kamdar
Copy link
Owner

Automatically run pre_build.sh if exists before building wheels and post_build.sh after building wheels.

  • Add support for pre_build.sh
  • Add support for post_build.sh
@mozman
Copy link

mozman commented Dec 11, 2020

Hi!

Thank you for your work and a pre_build.sh would be a nice feature. I had to fork your repository to add a python -m pip install cython.

A similar build system (https://github.com/marketplace/actions/python-wheels-manylinux-build) can pass options in the yaml file, I would just need the build-requirements:

uses: RalfG/[email protected]_x86_64
with:
  python-versions: 'cp36-cp36m cp37-cp37m'
  build-requirements: 'cython numpy'
  system-packages: 'lrzip-devel zlib-devel'
  pre-build-command: 'sh pre-build-script.sh'
  package-path: 'my_project'
  pip-wheel-args: '-w ./dist --no-deps'

Best regards,
Manfred

@Niraj-Kamdar
Copy link
Owner Author

I have created a patch so that people can run any command in a script before the actual build process starts. Currently, I haven't merged it in master since I haven't yet tested that feature but once I do, I will add it in master. Meanwhile, You can try it out using pre-build branch action instead of master.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants