Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include files missing from PyPy installation #51

Open
KrisThielemans opened this issue Nov 26, 2023 · 2 comments · May be fixed by #53
Open

include files missing from PyPy installation #51

KrisThielemans opened this issue Nov 26, 2023 · 2 comments · May be fixed by #53

Comments

@KrisThielemans
Copy link

UCL/STIR#1292 creates a GitHub action which installs nipet from pypy in a venv. However, prjb.h is not included as far as I can see. More detail in UCL/STIR#1292 (comment)

@KrisThielemans
Copy link
Author

Confirmed on WSL2 with Ubuntu 22.04:

$ python3 -m venv ~/nipet-venv
$ source ~/nipet-venv/bin/activate
$ pip install "nipet>=2"
$ find  /home/kris/nipet-venv -name \*.h|grep nifty
/home/kris/nipet-venv/lib/python3.10/site-packages/niftypet/nimpa/include/nlm.h
/home/kris/nipet-venv/lib/python3.10/site-packages/niftypet/nimpa/include/isub.h
/home/kris/nipet-venv/lib/python3.10/site-packages/niftypet/nimpa/include/cuhelpers.h
/home/kris/nipet-venv/lib/python3.10/site-packages/niftypet/nimpa/include/rsmpl.h
/home/kris/nipet-venv/lib/python3.10/site-packages/niftypet/nimpa/include/conv.h
/home/kris/nipet-venv/lib/python3.10/site-packages/niftypet/nipet/include/scanner_0.h
/home/kris/nipet-venv/lib/python3.10/site-packages/niftypet/nipet/include/def.h
/home/kris/nipet-venv/lib/python3.10/site-packages/niftypet/nipet/include/auxmath.h

@KrisThielemans
Copy link
Author

Seems to be missing something like this in prj/CMakeLists.txt

file(GLOB include_files "*.h")
install(FILES  ${include_files} niftypet/${CMAKE_PROJECT_NAME}/include)

Probably required in other directories as well.

@KrisThielemans KrisThielemans linked a pull request Nov 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant