Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(evm-ante): Use protobuf ABCI event instead of legacy event #1920

Closed
Tracked by #1836
Unique-Divine opened this issue Jun 11, 2024 · 1 comment
Closed
Tracked by #1836
Labels
x: evm Relates to Nibiru EVM or the EVM Module

Comments

@Unique-Divine
Copy link
Member

Following from changes in #1912

@Unique-Divine
Copy link
Member Author

Notes

Now, the EVM events are structured like this:

  1. pending_ethereum_tx - untyped event, emitted within evm ante handler.
    Left untyped because it could be used by Tendermint TxSearch which cannot parse wrapper quotes in a typed event value.

  2. eth.evm.v1.EventEthereumTx - typed event, contains more info about ethereum tx. Used for getting TxReceipt.

  3. message - untyped event with attr module (evm), sender and tx_type (legacy, accessList or DynamicFee) - left untyped because it's being used for event subscription (for eth it's used in eth_filterLogs)

  4. eth.evm.v1.EventTxLog - typed event, stores evm execution logs. Used in log queries.

  5. Additional typed events which are emitted depending on Tx action: EventContractDeployed, EventContractExecuted or EventTransfer.

  6. eth.evm.v1.EventBlockBloom - typed event emitted in the end of the block and used for event filtering.

TmTxIndexer vs EVM Indexer

One of the indexers must be turned on public nodes. With both turned off EVM Tx will not get a proper receipt and several queries will fail.

Fix tx_index

Fixed issue with tx_index discrepancy between ante handler event and apply evm event.

Proto Break

Removed typed EventMessage as we have to go with the untyped one. See above.

@github-project-automation github-project-automation bot moved this from ⚡ Building 🧱 to ✅ Completed in ⚛️ Nibiru (Hougyoku) Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x: evm Relates to Nibiru EVM or the EVM Module
Projects
Archived in project
Development

No branches or pull requests

2 participants