Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpr_photo_qa_df to find duplicate photo names and produce data frame showing missing photos and sites with duplicates #47

Open
NewGraphEnvironment opened this issue Dec 7, 2023 · 2 comments

Comments

@NewGraphEnvironment
Copy link
Owner

NewGraphEnvironment commented Dec 7, 2023

related to #46 because will now look for exact keyword matches within overall photo name string in format _keyword.

This waws closed when function first created

@NewGraphEnvironment NewGraphEnvironment changed the title make new function fpr_photo_qa_df to find duplicate photo names and produce data frame showing missing photos and sites with duplicates fpr_photo_qa_df to find duplicate photo names and produce data frame showing missing photos and sites with duplicates Dec 8, 2023
@NewGraphEnvironment
Copy link
Owner Author

NewGraphEnvironment commented Dec 8, 2023

  • modify the function so that it can look for photos in any location vs just 'data/photos'

  • solution involves nesting fpr_photo_qa_prep within fpr_photo_qa which should be fine

  • Although this was closed here when this change was made we see some strange behaviour in that thefpr_photo_qa function now modified to take any file path is working without having one of the params provided (dat = pscis_all). It seems that because we are feeding it an unnamed dataframe (it actually is pscis_all but it is unnamed) within fpr_photo_qa_df it works. Seems weird, but maybe makes sense.... Could rear its head somewhere.....

@NewGraphEnvironment
Copy link
Owner Author

move to fs package so we don't need to include the trailing slash in dir_photos param. This means all the helper functions need the update since that is what it is passed to...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant