add function fpr_photo_rename to sort photos into directories and append photo name to end of photo file name

[NewGraphEnvironment]

may as well use fpr for this for now. will close this when added NewGraphEnvironment/dff-2022#65

[NewGraphEnvironment]

could just append the _ds_ef1 or _ds as the col_string_add by pointing to location column after running some iteration of tidyr::separate(local_name, into = c('site_id', 'location', 'ef'), remove = F) type of thing to get site_id and ds_ef1 type split..... would reduce the size of the photo name and reduce risk of issues related to long file names we have seen in the past.....

may want to use a mutate and stringr::strsplit https://stackoverflow.com/questions/49752900/strsplit-and-keep-part-before-first-underscore though

[NewGraphEnvironment]

when photos are resized from original we change their extension to .JPG. This can cause errors in the function because the id of the photo is now different. Ideally we will resize and sort at the same time but for now we will put a mutate in the function to assume all .jpg are .JPG. This is a bit fragile but will do for now

[NewGraphEnvironment]

interestingly - the capitalization of .JPG vs .jpg is not an issue. not revising

[NewGraphEnvironment]

make default param col_string_append = location as per tidyr::separate(local_name, into = c('site_id', 'location'), remove = F, extra = "merge") call in fiss_site_tidy.R in

reason is to keep photo names as short as possible. b/c they are sorted to directories site_id is redundant

[NewGraphEnvironment]

just added photo_extra3 - 5 to the function but if they are not there in the dataframe the function now fails with

Error in `stopifnot()`:
ℹ In argument: `photo_renamed = dplyr::case_when(...)`.
Caused by error in `dplyr::case_when()`:
! Failed to evaluate the right-hand side of formula 5.
Caused by error:
! object 'photo_extra5_tag' not found
Backtrace:
  1. fpr::fpr_photo_rename(...)
 18. janitor::make_clean_names(...)
 19. janitor:::warn_micro_mu(string = string, replace = replace)
 20. base::grepl(x = string, pattern = current_unicode, fixed = TRUE)
 21. base::is.factor(x)
 22. 

The function fails if there is no photo_extra5_tag (like one of the old monitoring forms). removed the 5th one for now. Tried to abstrac the name of the tag column but couldn't get it to work yet