Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated the deep learning model #660

Open
bruAristimunha opened this issue Oct 9, 2024 · 3 comments
Open

Deprecated the deep learning model #660

bruAristimunha opened this issue Oct 9, 2024 · 3 comments

Comments

@bruAristimunha
Copy link
Collaborator

We have put a lot of effort into building a deep learning module, but clearly, this is not the best environment to maintain a deep learning library. I am proposing to deprecate the entire deep learning module and keep only the support for braindecode.

Currently, everything is already integrated into braindecode (EEGNeX, shallow, deep, eegnet and eegtcn), and it does not make much sense to have duplicate code.

Before officially removing the code duplication, a comparative study should be done and approved.

cc. @sylvchev and @carraraig

@bruAristimunha
Copy link
Collaborator Author

cc. @tomMoral too

@carraraig
Copy link
Collaborator

Hi @bruAristimunha ! I think on my side is the direction to go, since brain decode is well maintained. However I think can be useful to keep the current implementation in Tensorflow in order to ensure the full replicability of the MOABB benchmark. Maybe we can keep them in a separated folder. What do you think?

@PierreGtch
Copy link
Collaborator

Even if we remove it, the benchmark will be replicable by using the correct release.
Maybe we could simply add a tag in the repo on the commit people should use to replicate this benchmark?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants