Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Save Default Search Parameters in Profile #777

Open
WateryWafers opened this issue Nov 16, 2023 · 5 comments
Open

Feature Request: Save Default Search Parameters in Profile #777

WateryWafers opened this issue Nov 16, 2023 · 5 comments
Labels
enhancement Describes a "nice to have" feature, rather than a functional defect. nrdb-v2 Items pushed off to NRDB v2

Comments

@WateryWafers
Copy link

I would love to be able to set default values for some dropdown fields when using the card search feature.

For example/for my own uses, here's what I would set my defaults to:

Card pools & Ban Lists
Rotation - Active/Latest
Ban List - Active/Latest

Submit (filters)
Sort by - Faction
View as - Images Only

@plural plural added enhancement Describes a "nice to have" feature, rather than a functional defect. nrdb-v2 Items pushed off to NRDB v2 labels Jan 1, 2024
@AlexRodwell
Copy link
Contributor

Would be good to get a discussion going on this, since it's a useful feature, but expected implementation of it can vary a fair bit from person to person.

Here are some of my initial thoughts:

  • Would we want to offer this as a toggle/checkbox button so that the user has to interact/approve for it to be saved as their default search preference, or;
  • Automatically save and apply this, only if the user is logged in (although not all users might prefer this, as after their initial search on this, they then might have to have to edit 3 input separate inputs again if they wanted to change any of these defaults)

@AlexRodwell
Copy link
Contributor

AlexRodwell commented Jan 10, 2024

Perhaps we could add an additional option in the 'sort by' drop-down menu like so
image

That would only be added if the user is logged in and has previously searched before, therefore it becomes the 'default' option once those conditions are met. That would also make it easier to change later on if they wanted to swap from their defaults.

To expand on this suggestion, if 'Sort by Preferred' is select, it would use some JS to automatically take their preferred values (store in localStorage) and apply them to the other inputs, if the 'sort by' value changes to anything else, it will revert the other inputs to their default/1st option values. To handle a case when a user wants to update their preferences, I think utilising the 'save default search' toggle I mentioned previously in combination with this, would cover all edge-cases I can think of.

@jaimefps
Copy link

I'd love this feature. As someone that likes to bake original decks, it's a bit of a pain to select these filters constantly every time. In terms of implementation, a first easy approach could be to allow folks to select "defaults" in their profile. Ir could even be saved to Local Storage with an explicit caveat that the defaults are tied to the device/browser. In any case that would be a huge improvement from having to constantly select those exact 4 options that the OP mentioned.

@jaimefps
Copy link

Another approach could be to just add a small button next to the drop-downs in Card pools & Ban Lists that is "latest standard" which automatically sets the rotation and banlist drop-downs, assuming that the most frequent lookups are for standard legal cards anyways, in which case you wouldn't need to even save anything to a profile.

@jaimefps
Copy link

I haven't looked through the code, but I'd ask if nrdb has analytics to understand how most users leverage the Advanced search page, and be able to have a data-driven argument against just setting the default to what the OP said. I personally always use the same exact 4 options that the OP asked for, so I'd be more than happy if those were the global defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Describes a "nice to have" feature, rather than a functional defect. nrdb-v2 Items pushed off to NRDB v2
Projects
None yet
Development

No branches or pull requests

4 participants