Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

The extension should be rewritten from scratch. #2

Open
Naezr opened this issue Jun 8, 2024 · 2 comments
Open

The extension should be rewritten from scratch. #2

Naezr opened this issue Jun 8, 2024 · 2 comments

Comments

@Naezr
Copy link
Owner

Naezr commented Jun 8, 2024

Issues:

  • Working with multiple windows is broken. Basically, you have only one set of settings containing which toggles are enabled and which are not. When you toggle toggles in one window, it affects the second window as well, it just doesn't update. It's easier to explain using ShyFox as an example. Let's say you have two windows, all panels in both are hidden. You decide to display a sidebar in the first window. Then you decide to switch the navbar for the second window. The sidebar is activated along with the navbar. Because in the unified settings pool the sidebar is already enabled, and by clicking on the shortcut you have enabled the navbar and updated this window. If you go back to the first window and turn on the toolbar, the navbar will appear along with it. It's hard to explain in words, but if you just try it yourself, everything will become clear.

  • The settings page looks bad and requires you to constantly click on the “Apply settings” button. No explanation is needed here.

  • The extension code is just a mess. It's hard for me to understand this confusing code, it's easier to do everything myself from scratch. At the same time it will be a good practice in JS for me as a beginner.

@Naezr
Copy link
Owner Author

Naezr commented Jun 8, 2024

Joolee#6
this PR maybe very helpful

@Naezr
Copy link
Owner Author

Naezr commented Jul 29, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant