Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is gb_depth exactly? #22

Open
half-potato opened this issue Mar 22, 2023 · 1 comment
Open

What is gb_depth exactly? #22

half-potato opened this issue Mar 22, 2023 · 1 comment

Comments

@half-potato
Copy link

What exactly are these quantities? I'm trying to add this denoiser to a different method and I don't understand how to adapt my program accordingly. gb_depth appears to contain z0 and |z0-z1|, but I'm not sure what z0 and z1 are. I see they are derived quantities from interpolating triangles on the mesh, but what would these values be for a volumetric renderer using quadrature?

@jmunkberg
Copy link
Collaborator

jmunkberg commented Mar 22, 2023

See Appendix B in our paper: https://arxiv.org/pdf/2206.03380.pdf

The depth values are computed here, from the clip space coordinates
https://github.com/NVlabs/nvdiffrecmc/blob/main/render/render.py#L228

We adapt the SVGF denoiser, so please refer to that paper for details about the depth guide to the denoiser.
That denoiser is designed for surface geometry, and the guides (normals, depth) are assumed to be noise free.
It is not trivial to apply these guides to a volumetric renderer, which has a fuzzy depth. See e.g.: https://research.nvidia.com/publication/2021-03_interactive-path-tracing-and-reconstruction-sparse-volumes
for a discussion of volume denoising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants