Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

invalid metrics in 2.4.0rc2 #187

Open
juliantaylor opened this issue May 12, 2021 · 1 comment
Open

invalid metrics in 2.4.0rc2 #187

juliantaylor opened this issue May 12, 2021 · 1 comment

Comments

@juliantaylor
Copy link

https://github.com/NVIDIA/gpu-monitoring-tools/blob/master/pkg/pipeline.go#L182
only closes device label inside an if, if the condition is false invalid metrics are produced, e.g.

DCGM_FI_DEV_FB_FREE{gpu="0",UUID=uid",device="nvidia0,container="",namespace="",pod=""} 15109
pkg/pipeline.go:{{ $val.Name }}{gpu="{{ $val.GPU }}",{{ $val.UUID }}="{{ $val.GPUUUID }}",device="{{ $val.GPUDevice }}{{if $val.MigProfile}}",GPU_I_PROFILE="{{ $val.MigProfile }}",GPU_I_ID="{{ $val.GPUInstanceID }}{{end}}{{if $val.Hostname }}",Hostname="{{ $val.Hostname }}"{{end}}
@dbeer
Copy link
Contributor

dbeer commented May 14, 2021

This is fixed in master now. We will be making a new RC or an official release soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants