Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging tutorial notebook #3150

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SYangster
Copy link
Collaborator

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster force-pushed the logging_notebook branch 3 times, most recently from be2ca6a to fec4454 Compare January 17, 2025 19:12
@SYangster
Copy link
Collaborator Author

/build

"The log config file can easily be customized for different use cases.\n",
"\n",
"For this example, let's assume we are a federated learning researcher mainly interested in the algorithm parts of the log.\n",
"By default, we provide the FLFileHandler which uses the FLFilter to generate the log_fl.txt However we would also like to have a cleaner output in the console, as well as remove/shorten some unnecessary log fields.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest adding some reference to nvflare.fuel.utils.log_utils.LoggerNameFilter so we know this FLFilter is actually using that? (I know we have a section, maybe add some texts here to explain?)

examples/tutorials/logging.ipynb Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants