-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ResStockArgumentsPostHPXML measure #927
Comments
I defer to Scott on whether this is a good method. Can the setpoint schedules be appended to the existing schedules.csv or is there a reason they need to be separate? |
I think, yes, we could append new schedules to the existing schedules.csv. |
Cool; it seems easier from a user perspective. |
Note that appending new schedules will have a runtime performance impact because you have to read in the entire CSV, add the columns, and then write it back out. Might check how much time that takes for a 10-min or 1-min simulation. |
I guess we're having to read the entire CSV either way to find the occupied/unoccupied hours for use in the HVAC setpoint generation. But writing to disk is the expensive operation. |
Thanks. I'm fine with separate files if we think it is worth the time savings. cc @afontani in case he has an opinion on this. |
Are we going to be able to create new setpoint TSV files that avoid |
@joseph-robertson I don't think we do anything special to handle that now. |
Update the workflow to accommodate writing detailed schedule csv files. This will support:
Proposal:
BuildExistingModel
(andApplyUpgrade
) calls, in order:ResStockArguments
BuildResidentialHPXML
BuildResidentialScheduleFile
ResStockArgumentsPostHPXML
hpxml_path
output_csv_path
(forschedules.csv
generated byBuildResidentialScheduleFile
)options_lookup.tsv
schedules2.csv
(updateshpxml_path
's<SchedulesFilePath>
)HPXMLtoOpenStudio
ReportSimulationOutput
The text was updated successfully, but these errors were encountered: