Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate new ACCA Manual S #1521

Open
3 tasks
shorowit opened this issue Oct 19, 2023 · 3 comments · May be fixed by #1852
Open
3 tasks

Incorporate new ACCA Manual S #1521

shorowit opened this issue Oct 19, 2023 · 3 comments · May be fixed by #1852
Assignees
@Sashadf1
Labels
enhancement New feature or request priority medium

Comments

@shorowit
Copy link
Contributor

shorowit commented Oct 19, 2023 •
edited by Sashadf1
Loading

It is under review now and may be finalized in the near future.

Also look at replacing the TODO here; can use methods (e.g., CalculateSHR, CoilAoFactor, and CoilBypassFactor) in psychrometrics.rb?

TODO regarding hvac_sizing.rb replaced by #1707

  • What should the new default sizing methodology be?
  • Should we rename the HeatPumpSizingMethodology input to be more general (affects e.g. central ACs and furnaces too) -- ideally, yes
    • What input names (in HeatPumpSizingMethodology or equivalent) should we use for 2014 vs 2023 Manual S?
@shorowit shorowit added the enhancement New feature or request label Oct 19, 2023
@shorowit shorowit moved this from Triage to High Priority in OpenStudio-HPXML Oct 31, 2023
@shorowit shorowit moved this from High Priority to In progress in OpenStudio-HPXML Feb 6, 2024
@shorowit
Copy link
Contributor Author

shorowit commented Mar 5, 2024

A preview of Manual S third edition is available on the ACCA website.

@Sashadf1
Copy link
Collaborator

Sashadf1 commented Apr 2, 2024

Just found this issue and bookmarked it. I'll investigate psychometrics.rb and the methods mentioned above.

@shorowit shorowit assigned Sashadf1 and unassigned shorowit and afontani Apr 2, 2024
@Sashadf1
Copy link
Collaborator

Sashadf1 commented Oct 7, 2024

Regarding "should we rename the HeatPumpSizingMethodology input to be more general (affects e.g. central ACs and furnaces too)" --> I think yes. Heat pump sizing methodology does affect air conditioning equipment.

@shorowit shorowit linked a pull request Oct 15, 2024 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sashadf1 Sashadf1

Labels
enhancement New feature or request priority medium
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ACCA Manual S. Update NREL/OpenStudio-HPXML
3 participants
@shorowit @afontani @Sashadf1