Update an offline marine vrfy tool #1447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'u': [0, 0.2], | ||
| 'v': [0, 0.2]}, | ||
| 'u': [0, 5], | ||
| 'v': [0, 5]}, |
There was a problem hiding this comment.
oops, there's something wrong with the bkg error for u,v if we need to scale from 0 to 5m/s
There was a problem hiding this comment.
Will check it out accordingly
There was a problem hiding this comment.
Ranges for [0, 0.5] are quite reasonable, what do you think?
There was a problem hiding this comment.
Looks good, thanks for checking @apchoiCMD
There was a problem hiding this comment.
Will update this PR with recent development- thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update some features for avoiding fails of task and make the script easy to use
Companion PRs
N/A
Issues
Resolves #1384
Partially Resolves #1398
Automated CI tests to run in Global Workflow