Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Send Request.vi" should still send RPC request to handler on string error #5

Open
Electric-Spark opened this issue Nov 6, 2017 · 2 comments

Comments

@Electric-Spark
Copy link

It's annoying that if you feed a garabage string to the Send Request, that it can error on string parsing. So you have to add reactionary code there that mimics what you do in the "Error Receiving Command" case of the server.

Ideally, Send Request would still send the request which would trip the handling in the server. Seems like a double need for error checking without it. Unfortunantly, this is likely a breaking change since I'm guessing most folks have worked around this like I have and would now get two responses if the Send Request started sending it down :(

@Electric-Spark
Copy link
Author

Although I guess you could also argue that the ID value of async would then be invalid, which wouldn't make sense...so maybe the duplication is necessary.

@tannerblair
Copy link
Contributor

Your second comment is why I haven't solved this problem, but I'm open to suggestions on how to more elegantly handle this case while maintaining the decoupling of the two processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants