Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch_tls_key_passphrase containing $ not working #282

Open
ivareri opened this issue Oct 11, 2023 · 2 comments · May be fixed by #285
Open

elasticsearch_tls_key_passphrase containing $ not working #282

ivareri opened this issue Oct 11, 2023 · 2 comments · May be fixed by #285
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ivareri
Copy link
Contributor

ivareri commented Oct 11, 2023

elasticsearch_tls_key_passphrase with a $ character is not working. This is most likely due to using echo with " quotation. This will lead to parameter expansion, while using ' wont.

~ >>> echo "test$var@test"                                                                                                                                                                
test@test

vs

~ >>> echo 'test$var@test'                                                                                                                                                                
test$var@test

This is done several places in elasticsearch-keystore.yml, like here

@widhalmt widhalmt added the bug Something isn't working label Oct 11, 2023
@widhalmt widhalmt self-assigned this Oct 11, 2023
@widhalmt
Copy link
Member

Good catch! Thank you. I'll look into it. I guess, I'll work it into a test case and then fix it.

@widhalmt widhalmt added this to the 1.0.0 milestone Oct 11, 2023
@widhalmt
Copy link
Member

I submitted a draft of a pull request with your suggested solution. Unfortunately it seems, that's not enough to fix the problem. I'll keep investigating. Please follow the PR and if you have anything to add, feel free to do there.

@widhalmt widhalmt modified the milestones: 1.0.0, 0.1.0 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants