Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 11 tests fail #141

Closed
K20shores opened this issue Sep 26, 2023 · 1 comment · Fixed by #142
Closed

Windows 11 tests fail #141

K20shores opened this issue Sep 26, 2023 · 1 comment · Fixed by #142
Assignees
@K20shores
Labels
bug Something isn't working

Comments

@K20shores
Copy link
Collaborator

Building the docker image on windows 11 causes the tests to fail. The image builds, but for some reason the tests think they can't find the binary and/or the config file. But, running the tests by hand causes them to pass. Maybe this is some sort of docker virtualization issue? Either way, a potential fix may be installing the binary system wide
@K20shores
Copy link
Collaborator Author

This seems to be caused by windows converting files to end with \r\n instead of \n, so things like the shebang in our test scripts are really showing up as /bin/bash\r, which is not a binary.... figured out from this SO post

@K20shores K20shores self-assigned this Sep 26, 2023
@K20shores K20shores linked a pull request Sep 26, 2023 that will close this issue
adding instructions for windows users #142
Merged
@K20shores K20shores mentioned this issue Sep 26, 2023
Merged
@mattldawson mattldawson added the bug Something isn't working label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@K20shores K20shores

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding instructions for windows users NCAR/music-box
2 participants
@mattldawson @K20shores