New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trainerERA5_v2.py not throwing exception when valid_forecast_len > 0 #138

Open

dkimpara opened this issue Dec 23, 2024 · 1 comment

Assignees

Collaborator

dkimpara commented Dec 23, 2024

issue:

when exception not thrown in validation method, code errors out

root cause:

total_time_steps is set by the parser to be equal to (train) forecast_len
error handling uses total_time_steps

possible fixes:

deprecate total_time_steps (only used in single-step training)

dkimpara assigned dkimpara and jsschreck

Collaborator Author

dkimpara commented Dec 23, 2024

@jsschreck can i deprecate total_time_steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment