Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forecast_len: 0 is confusing #126

Open
sethmcg opened this issue Oct 28, 2024 · 0 comments
Open

forecast_len: 0 is confusing #126

sethmcg opened this issue Oct 28, 2024 · 0 comments

Comments

@sethmcg
Copy link
Collaborator

sethmcg commented Oct 28, 2024

The model config files (e.g., example.yml) use array index offsets for length parameters. E.g., for single-step training, the model returns indexes i to i+0, so the yaml file says forecast_len: 0.

This is confusing for end-users. If the model is predicting one step ahead and returning a single timestep, the length of the forecast is 1 timestep, so the forecast_len parameter should be 1, not 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant