Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed_dz_advection: include in code | remove from namelist #135

Open
bertjebertjek opened this issue Jul 8, 2022 · 1 comment
Open

fixed_dz_advection: include in code | remove from namelist #135

bertjebertjek opened this issue Jul 8, 2022 · 1 comment

Comments

@bertjebertjek
Copy link
Contributor

The fixed_dz_advection flag in the namelist is confusing for all but the most experienced users. For certain (most?) applications it should be set to true to produce realistic behaviour, after Dylans modifications of the advection code. Therefore I suggest we hardcode the desired behaviour into either the advection or wind code and remove the flag from the namelist.

Expected Behavior

for anything but linear theory in the wind settings, fixed_dz_advection should be TRUE. (but @gutmann can confirm this).

@gutmann
Copy link
Member

gutmann commented Jan 23, 2023

@bertjebertjek is this done now? If not, can you implement exactly this (hard code the desired behavior) It may be simplest at first to hard code the setting for fixed_dz_advection based on the selected wind scheme in the options object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants