Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GA-1507] Add more testing to ncl/receipts/days_in_month.ipynb to flesh out differences in "standard" and "gregorian" calendars #48

Open
anissa111 opened this issue Jun 3, 2024 · 2 comments
Assignees
Labels
ncl Related to ncl specific content testing Issue related to testing unassigned Grabbable issue that requires project knowledge

Comments

@anissa111
Copy link
Member

#44 discovered some differences in the NCL and cftime gregorian and standard calendars.

We should add more receipts testing to fully understand the differences.

Depends on #44

@anissa111 anissa111 added testing Issue related to testing blocked Work blocked waiting on the output of some other source/work unassigned Grabbable issue that requires project knowledge ncl Related to ncl specific content labels Jun 3, 2024
@kafitzgerald
Copy link
Collaborator

I went down the rabbit hole a bit and I'm guessing it's because this (i.e. the interpretation of calendars for days_in_month) seems to all be custom in NCL: https://github.com/NCAR/ncl/blob/edd46f5426286146313b31bd6826e3d3c360c0dc/ni/src/lib/nfp/datesW.c#L760

And defined in ways that don't align with the CF conventions or UDUNITS.

@kafitzgerald
Copy link
Collaborator

This is also relevant: https://github.com/NCAR/ncl/blob/edd46f5426286146313b31bd6826e3d3c360c0dc/ni/src/lib/nfp/datesW.c#L1015

So effectively in NCL for this function anyway (and likely some others, but maybe not all) the "none", "standard", and "gregorian" calendars are all "proleptic_gregorian" calendars 🙃 .

@kafitzgerald kafitzgerald removed the blocked Work blocked waiting on the output of some other source/work label Aug 22, 2024
@kafitzgerald kafitzgerald self-assigned this Aug 22, 2024
@anissa111 anissa111 changed the title Add more testing to ncl/receipts/days_in_month.ipynb to flesh out differences in "standard" and "gregorian" calendars [GA-1507] Add more testing to ncl/receipts/days_in_month.ipynb to flesh out differences in "standard" and "gregorian" calendars Sep 13, 2024
@kafitzgerald kafitzgerald self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ncl Related to ncl specific content testing Issue related to testing unassigned Grabbable issue that requires project knowledge
Projects
None yet
Development

No branches or pull requests

2 participants