Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want deep archive to support LBLX label extensions #157

Open
tbarnes4 opened this issue Feb 5, 2024 · 17 comments
Open

As a user, I want deep archive to support LBLX label extensions #157

tbarnes4 opened this issue Feb 5, 2024 · 17 comments

Comments

@tbarnes4
Copy link

tbarnes4 commented Feb 5, 2024

Checked for duplicates

No - I haven't checked

πŸ› Describe the bug

When I run the software on a bundle that has only lblx files, the software runs without errors, but produces empty SIP, checksum, and manifest *.tab files.

πŸ•΅οΈ Expected behavior

I expect the software to create the tables as if the bundle contained xml labels.

πŸ“œ To Reproduce

  1. Run pds-deep-archive
  2. Ex: pds-deep-archive -s PDS_SBN -b https://pdssbn.astro.umd.edu/holdings/ --include-latest-collection-only pds4-nh_documents-v1.0/bundle.lblx

...

πŸ–₯ Environment Info

  • Version of this software 1.1.4
  • Operating System: MacOSX 12.6.8 and Red Hat Enterprise Linux 9.3
    ...

πŸ“š Version of Software Used

pds-deep-archive 1.1.4

🩺 Test Data / Additional context

https://pdssbn.astro.umd.edu/holdings/pds4-nh_documents-v1.0

πŸ¦„ Related requirements

πŸ¦„ #xyz

βš™οΈ Engineering Details

No response

@tbarnes4 tbarnes4 added bug Something isn't working needs:triage labels Feb 5, 2024
@tbarnes4
Copy link
Author

@jordanpadams Since I've seen no further comment on this, just pinging again.

@jordanpadams jordanpadams changed the title pds-deep-archive creates empty tables for bundles that use lblx labels As a user, I want deep archive to support LBLX files on the file system. Feb 23, 2024
@jordanpadams jordanpadams removed their assignment Feb 23, 2024
@jordanpadams
Copy link
Member

@tbarnes4 thanks for the ping. I updated this ticket to be a new requirement since this is an overall new requirement on the system that was not implemented yet.

That being said, we added this to the backlog, but it is not on the top of our radar since there is a workaround.

If you load this data into the Registry/API (which it looks like it is), then you can run pds-deep-registry-archive to generate the SIPs much easier (and faster), not to mention it is a good forcing factor to load the data into the registry.

$ pds-deep-registry-archive --site PDS_SBN urn:nasa:pds:nh_documents::1.0

@jordanpadams jordanpadams removed the bug Something isn't working label Feb 23, 2024
@jordanpadams jordanpadams changed the title As a user, I want deep archive to support LBLX files on the file system. As a user, I want deep archive to support LBLX label extensions Feb 23, 2024
@tbarnes4
Copy link
Author

@jordanpadams Thanks! I was thinking of trying that work around as well. It would be the first we've done from SBN-UMD thru the registry, so that will be fun.

@jordanpadams
Copy link
Member

@tbarnes4 actually... standby on running deep-archive. I forgot we have a bug right now. A PR is up and we will hopefully have a new version tagged by end of day (or first thing Monday).

@jordanpadams
Copy link
Member

jordanpadams commented Feb 27, 2024

@tbarnes4 you should be able to upgrade your PDS Deep Archive software and run the utility as described above. I just tested it and it appears to work great.

@tbarnes4
Copy link
Author

@jordanpadams Upgraded to v1.1.15 on two different systems (same as above) and I am still getting the same result with the same bundle (as above) where the 3 *tab files are all empty.

% source ~/.virtualenvs/pds-deep-archive/bin/activate.csh
% pds-deep-archive -s PDS_SBN -b https://pdssbn.astro.umd.edu/holdings/ pds4-nh_documents-v1.0/bundle.lblx
INFO πŸ‘Ÿ PDS Deep Archive, version 1.1.5
INFO πŸƒβ€β™€οΈ Starting AIP generation for pds4-nh_documents-v1.0/bundle.lblx
INFO πŸŽ‰ Success! AIP done, files generated:
INFO πŸ“„ Checksum manifest: nh_documents_v1.0_20240227_checksum_manifest_v1.0.tab
INFO πŸ“„ Transfer manifest: nh_documents_v1.0_20240227_transfer_manifest_v1.0.tab
INFO πŸ“„ XML label for them both: nh_documents_v1.0_20240227_aip_v1.0.xml
INFO πŸƒβ€β™€οΈ Starting SIP generation for pds4-nh_documents-v1.0/bundle.lblx
INFO πŸŽ‰ Success! From /Volumes/echeclus02/TEMP/nssdc_test/pds4-nh_documents-v1.0/bundle.lblx, generated these output files:
INFO πŸ“„ SIP Manifest: nh_documents_v1.0_20240227_sip_v1.0.tab
INFO πŸ“„ XML label for the SIP: nh_documents_v1.0_20240227_sip_v1.0.xml
INFO πŸ‘‹ That's it for now. Bye.

@jordanpadams
Copy link
Member

@tbarnes4 sorry for the confusion, I meant you are good to use the pds-deep-registry-archive utility to generate the SIPs using the next-gen Registry. This requirement has still not been implemented, and will unfortunately not be implemented for a bit since we have a known workaround.

@tbarnes4
Copy link
Author

@jordanpadams That makes much more sense. Tracking down other issues and I felt I was going crazy. I expect to try the registry-archive later.

@jordanpadams
Copy link
Member

@tbarnes4 copy that. it should take ~30 seconds to try it :-) . and you can run it from anywhere (your own laptop works).

@tbarnes4
Copy link
Author

@jordanpadams That it does, even less. For kicks and giggles tried a collection LIDVID and it errored out with unexpected errors. But can't expect it to do things it wasn't designed to do. ;-)

@smclaughlin7
Copy link

Subscribed to monitor progress. @tbarnes4 Do you expect to submit this bundle shortly after deep archive is enhanced?

@smclaughlin7
Copy link

@jordanpadams Should NSSDCA expect Deep Archive tool continue to use '.xml' as the extension for SIP products, at least until IM 2.0? I assume '.lblx' is not presently an option for that tool, correct? Thanks!

@jordanpadams
Copy link
Member

@smclaughlin7 correct. And I am not even sure we will be upgrading with IM 2.0 since all of these SIPs belong to the same collection. We don't plan on going back and reprocessing those SIPs to use lblx.

@smclaughlin7
Copy link

@jordanpadams Thanks! We/NSSDCA will continue to expect only '.xml' for SIPs.

@tbarnes4
Copy link
Author

Subscribed to monitor progress. @tbarnes4 Do you expect to submit this bundle shortly after deep archive is enhanced?

@smclaughlin7 Sorry for the delay. I have just submitted the two bundles. Hopefully they go thru without problem. Thanks!

@tbarnes4
Copy link
Author

tbarnes4 commented Sep 5, 2024

@jordanpadams I think this needs to be addressed sooner. I have been sitting on data sets in hopes to register them and then using the pds-deep-registry-archive, but it has been months since we have been able to register new data. I have submitted my non-lblx data, but I am unable to submit my data sets that utilize lblx label file extensions. Is there a quick fix? It is not good for us to sit on ready to deep archive data. Thanks.

@jordanpadams
Copy link
Member

@tbarnes4 apologies for the delay, but we have no available staff to work on this at this time, as we have been focused on getting the Registry up and running, which was completed last week. Pat should be receiving info to again begin loading data into the registry. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants