Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common.SLE doesn't pull all attributes from kwargs #108

Closed
MJJoyce opened this issue May 1, 2020 · 0 comments · Fixed by #109
Closed

common.SLE doesn't pull all attributes from kwargs #108

MJJoyce opened this issue May 1, 2020 · 0 comments · Fixed by #109
Assignees
@MJJoyce

Comments

@MJJoyce
Copy link
Member

MJJoyce commented May 1, 2020

common.SLE is missing a check for kwargs value for some of its attributes. This should be updated so any of the attributes that it's attempting to pull from the config is also pulled from kwargs if it exists. Note, we will adjust the ordering of the checks in #95
@MJJoyce MJJoyce self-assigned this May 1, 2020
MJJoyce added a commit that referenced this issue May 1, 2020
@MJJoyce
Issue #108 - Pull all attributes from kwargs and config
2939cb9
@MJJoyce MJJoyce mentioned this issue May 1, 2020
Merged
MJJoyce added a commit that referenced this issue May 27, 2020
@MJJoyce
Merge pull request #109 from NASA-AMMOS/issue-108
e4b2825 
Issue #108 - Pull all attributes from kwargs and config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MJJoyce MJJoyce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #108 - Pull all attributes from kwargs and config NASA-AMMOS/AIT-DSN
1 participant
@MJJoyce