Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve site-builder UX #92

Closed
4 tasks done
mlegner opened this issue Jun 19, 2024 · 3 comments
Closed
4 tasks done

Improve site-builder UX #92

mlegner opened this issue Jun 19, 2024 · 3 comments

Comments

@mlegner
Copy link
Collaborator

mlegner commented Jun 19, 2024

@Tzal3x
Copy link
Collaborator

Tzal3x commented Jul 18, 2024

Hey @mlegner can you elaborate more on the following?

  1. improve the site-builder defaults
  2. add confirmation for the transaction

Is this issue currently developed? If so I can start working on it!

@mlegner
Copy link
Collaborator Author

mlegner commented Jul 18, 2024

Oh, that's a very good question. I think I just took those from https://github.com/MystenLabs/walrus/issues/360, so @giac-mysten might know a bit more...

Regarding the defaults, one nice improvement could be not to require the user to specify a config file if they just want to use the default settings and/or look for the config file in some default locations. (Although I'm not sure that was the original intent.)

In any case, nobody is working on this at the moment.

@giac-mysten
Copy link
Collaborator

I think "improving the defaults" was about looking for the config files in default locations... Some of this work is already done, but maybe we could have something similar to the walrus binary, where the site-builder looks for the binary in ~/.config (@mlegner did we settle the discussion on where the configs should go?) and then tries ./assets/builder-example.yaml

add confirmation for the transaction

This is a follow up to the --dry-run work. The idea would be for the client to determine the price of creating/updating the site, displaying it to the user, and then asking "publishing/updating will cost XYZ SUI. do you want to proceed with the transaction?". Such that there are no surprises on that front

@Tzal3x Tzal3x self-assigned this Jul 19, 2024
@Tzal3x Tzal3x removed their assignment Oct 3, 2024
@linear linear bot closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants