Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update domain_parsing.ts to support walrus.site suffix #124

Open
1 task done
Tzal3x opened this issue Jul 23, 2024 · 0 comments
Open
1 task done

Update domain_parsing.ts to support walrus.site suffix #124

Tzal3x opened this issue Jul 23, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request portal

Comments

@Tzal3x
Copy link
Collaborator

Tzal3x commented Jul 23, 2024

Description

At the moment the domain_parsing.ts functions work because the walrus.site is not registered to the public suffix list.

For this reason we use a fixed version of the public suffix list that is downloaded with the v8.0.2 release of parse-domain. This is done so that when the walrus.site gets added to the list, our code will still work.

⚠️ As soon as we include the walrus.site to the public suffix list, (#64), we should update those functions to parse the domain and subdomains correctly (i.e. given the new version of the suffix list, the existing unit tests should pass).
Plus we need to find a way to update the suffix list periodically npx parse-domain-update during the build process so that we use each time the latest public suffix list, and no longer use the fixed version of it.

Related comment: #121 (comment)

Component

portal

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@Tzal3x Tzal3x added enhancement New feature or request portal labels Jul 23, 2024
@Tzal3x Tzal3x self-assigned this Jul 23, 2024
@Tzal3x Tzal3x added the bug Something isn't working label Jul 23, 2024
@Tzal3x Tzal3x removed their assignment Oct 3, 2024
@Tzal3x Tzal3x changed the title [Feature]: Update domain_parsing.ts to support walrus.site suffix Update domain_parsing.ts to support walrus.site suffix Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request portal
Projects
None yet
Development

No branches or pull requests

1 participant