Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThemeManager planned improvements, feedback wanted #31

Open
digitaldirk opened this issue Sep 17, 2024 · 6 comments
Open

ThemeManager planned improvements, feedback wanted #31

digitaldirk opened this issue Sep 17, 2024 · 6 comments

Comments

@digitaldirk
Copy link
Contributor

digitaldirk commented Sep 17, 2024

Hi,

I would like to become a main contributor/maintainer for this project.

Contribution Ideas:

  1. Update demo project (maybe add to mublazor docs)
  2. Add more options (upcoming skeleton color for example: MudSkeleton: add dark mode support MudBlazor#9815)
  3. Add presets (Default, pastel, neon,...)
  4. Ability to load custom fonts
  5. Exporting/importing themes (See Save theme #3)
  6. Improve readme
  7. Performance/stability
  8. Diagnostics (warnings for accessibility and contrast for example)
  9. Add tests
  10. Make things more compact overall (dense/margin) to be able to show as many things as possible on demo page.

Would like to discuss these further here with the community.

@ScarletKuro
Copy link
Member

I would like to become a main contributor/maintainer for this project. @ScarletKuro @henon

I think @henon would need your discord to discuss this.

As for the features. I think it's more to @Garderoben since he wrote 99% of the code, I'm just life supporting it.
I can only say that the most requested feature was to import/export the theme settings.

@digitaldirk digitaldirk changed the title ThemeManager planned improvements/Wanting to become maintainer ThemeManager planned improvements, feedback wanted Sep 18, 2024
@digitaldirk
Copy link
Contributor Author

Here is a rough idea of having the drawer come up from the bottom instead.
drawerchangestest

@ScarletKuro ScarletKuro pinned this issue Sep 18, 2024
@digitaldirk
Copy link
Contributor Author

digitaldirk commented Sep 24, 2024

Exporting/Uploading a json file is working, but still have some issues to work out. For exporting I would like to have multiple options.

What exports would you want?

  • .json file?
  • Copy/pasteable C# code?
  • .cs file?
  • Export just the colors as rgb/hex?

mudthemeupload

I will be away for 1-2 weeks so no coding progress will be made, but I will be sure to respond to any feedback.

@ScarletKuro
Copy link
Member

I would say you only need the json and copy/pastable C# code for the MudTheme for your project. Not sure about other formats

@Allann
Copy link

Allann commented Nov 4, 2024

Not sure if you'd like to add another item to the list? SSR support as it currently only works with CSR.

@Miclo
Copy link

Miclo commented Dec 2, 2024

It would be nice if all the configurable colors, elevations, texts etc would be on a sample page and were manageable by the thememanager. For me the thememanager on the side would be best, since I have a 40" monitor (wide), but perhaps you can make that configurable as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants