Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive #15

Open
mrx23dot opened this issue Jan 28, 2022 · 1 comment
Open

False positive #15

mrx23dot opened this issue Jan 28, 2022 · 1 comment

Comments

@mrx23dot
Copy link

Source for
https://etherscan.io/address/0x496299d8497a02b01f5bc355298b0a831f06c522#code
shows no suicide/selfdestruct but sript claims it has.

@thedavidmeister
Copy link

hmmm, i ported this to solidity so that the scan can be done just by calling on onchain function

https://github.com/rainprotocol/rain.extrospection/blob/main/src/LibExtrospectBytecode.sol#L20

i did not see the false positive in tests

https://github.com/rainprotocol/rain.extrospection/blob/main/test/LibExtrospectBytecode.scanEVMOpcodesReachableInBytecode.t.sol#L98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants