Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove calculation of good channels on data load #45

Open
shashwatsridhar opened this issue Nov 12, 2020 · 0 comments
Open

remove calculation of good channels on data load #45

shashwatsridhar opened this issue Nov 12, 2020 · 0 comments

Comments

@shashwatsridhar
Copy link
Collaborator

The calculation good channels takes place during data loading in the current implementation of pykilosort. This is done differently in the matlab version, wherein the good channels are calculated as a part of the preprocessing step and the probe view is updated thereafter. This should be the default behaviour in pykilosort as well, and would speed up data loading significantly.

Note: this is necessary to mimic the functionality of Kilosort2, but the calculation of good channels is likely to be redundant in the upcoming datashift version of Kilosort / Pykilosort. @marius10p can correct me if I'm wrong here

shashwatsridhar added a commit to shashwatsridhar/pykilosort that referenced this issue May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant