Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: speed up computation of whitening matrix on-the-fly #43

Open
shashwatsridhar opened this issue Nov 12, 2020 · 0 comments
Open

GUI: speed up computation of whitening matrix on-the-fly #43

shashwatsridhar opened this issue Nov 12, 2020 · 0 comments

Comments

@shashwatsridhar
Copy link
Collaborator

Whenever the user views the whitened / predicted / residual version of the loaded data for the first time, the whitening matrix is calculated and then cached. In the current implementation this calculation is slow to the point that for large datasets, it could take on the order of tens of seconds to calculate the matrix. This happens because the whitening matrix is calculated using the entire dataset.

This is unnecessary since the on-the-fly calculation can be more approximate and use, as is the case in the matlab version, ~5 batches of the data. This would speed up the calculation irrespective of the data size.

Note: the whitening step that's a part of the preprocessing will still use the entire dataset.

shashwatsridhar added a commit to shashwatsridhar/pykilosort that referenced this issue May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant