Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeoutForFirmwareUpdate defaults to 15000, but should default to Timeout instead #1838

Open
neilenns opened this issue Oct 14, 2024 · 0 comments · May be fixed by #1839
Open

TimeoutForFirmwareUpdate defaults to 15000, but should default to Timeout instead #1838

neilenns opened this issue Oct 14, 2024 · 0 comments · May be fixed by #1839
Assignees
@neilenns
Labels
enhancement Improvement of an existing feature

Comments

@neilenns
Copy link
Contributor

Found by Ralf. When flashing large firmware files to the Mega, Mobiflight will attempt to query via GetInfo before the flashing is complete, even if you set Timeout to a higher value.

This is because by default the TimeoutForFirmwareUpdate property is omitted from the mega.board.json file and you have to know to set it.

Instead, we should just default TimeoutForFirmwareUpdate to the value of Timeout if no specific one is specified in the board.json file.
@neilenns neilenns added the enhancement Improvement of an existing feature label Oct 14, 2024
@neilenns neilenns self-assigned this Oct 14, 2024
neilenns added a commit to neilenns/MobiFlight-Connector that referenced this issue Oct 14, 2024
@neilenns
Default TimeoutForFirmwareUpdate to Timeout
f7ccdc5 
Fixes MobiFlight#1838
@neilenns neilenns linked a pull request Oct 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neilenns neilenns

Labels
enhancement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default TimeoutForFirmwareUpdate to Timeout neilenns/MobiFlight-Connector
1 participant
@neilenns